Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subscription): Support specified pk read log store #19274

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Nov 6, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In this pr we will save the pk consumed by the cursor every time, and support the specified pk consumption log, this but this pr does not use them at present, we will open the cursor recovery in the next pr

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxhZs xxhZs marked this pull request as ready for review November 7, 2024 06:50
@graphite-app graphite-app bot requested a review from a team November 7, 2024 07:20
@xxhZs xxhZs force-pushed the xxh/timeout-base-recovery-cursor branch from d53bf7a to 7f4e0cd Compare November 8, 2024 08:43
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feat is not used in cursor manager currently and there is no test on it. How do we verify that it is working as expected?

src/batch/src/executor/row_seq_scan.rs Outdated Show resolved Hide resolved
src/batch/src/executor/log_row_seq_scan.rs Outdated Show resolved Hide resolved
src/common/src/array/struct_array.rs Show resolved Hide resolved
@@ -47,6 +47,15 @@ where
})
}

#[function("cast(varchar) -> struct", type_infer = "unreachable")]
pub fn str_parse_struct(elem: &str, ctx: &Context) -> Result<StructValue> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change relevant to this PR?

Copy link
Contributor Author

@xxhZs xxhZs Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is to enable recovery from a single point, his logic = select * from table where (pk1,pk2,pk3)>(1,1,1);

src/frontend/src/handler/util.rs Outdated Show resolved Hide resolved
@graphite-app graphite-app bot requested a review from a team December 12, 2024 09:59
@xxhZs xxhZs requested a review from hzxa21 December 13, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants